lkml.org 
[lkml]   [2004]   [Sep]   [25]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.9-rc2-mm3
FromXavier Bestel <>
DateSat, 25 Sep 2004 11:27:49 +0200
Le sam 25/09/2004 à 11:19, Russell King a écrit :

> I wonder if we should consider adding:
> 
> 	WARN_ON(!spin_is_locked(&tty_termios_lock));
> 
> in there.
> 
> However, the one annoying thing about "spin_is_locked" is that, on UP,
> it defaults to "unlocked" which makes these kinds of checks too noisy.
> Maybe we need a spin_is_locked() with a bias towards being locked for UP?

Or something like:

#define spin_is_safe(lock) ((!CONFIG_SMP) || spin_is_locked(lock))
(maybe as an inline)

	Xav

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [from the cache]
©2003-2008