lkml.org 
[lkml]   [2004]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] voluntary-preempt-2.6.9-rc2-mm3-S5

    * K.R. Foley <kr@cybsft.com> wrote:

    > The following, on top of Ingo's patch above, fixes the problem with
    > dropping new connections and doesn't have any adverse affects that
    > I've seen:
    >
    > --- linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c.orig 2004-09-23
    > 22:16:42.249435870 -0500
    > +++ linux-2.6.9-rc2-pre-mm3/net/ipv4/tcp_output.c 2004-09-23
    > 22:12:03.911811945 -0500
    > @@ -699,11 +699,6 @@
    >
    > tcp_minshall_update(tp, mss_now, skb);
    > sent_pkts = 1;
    > - /*
    > - * Break out early - we'll continue later:
    > - */
    > - if (softirq_need_resched())
    > - break;

    hm, ok, i'll revert this in my tree. I suspect we'll see some latencies
    resurfacing under high network load again, but correctness goes first
    obviously. If then we'll have to find some other method to break that
    critical path.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.030 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site