lkml.org 
[lkml]   [2004]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 03/21] video/radeon_base: replace MS_TO_HZ() with msecs_to_jiffies()
Date
On Thursday 23 September 2004 16:31, janitor@sternwelten.at wrote:
>I would appreciate any comments from the janitors list.

Well, I'm not a janitor, but this patch tickled my fancy enough to
apply it just for grins, and there is now a wide one here at the
Heskett digs. Running 2.6.9-rc2-mm2 without this patch, my glxgears
speeds are fixed +- a half a frame a second from 10 fps. Thats real
exciting, like watching grass grow or paint dry.

However, after applying this patch only, my glxgears performance is
looking up a bit, as follows:
root@coyote root]# glxgears
1254 frames in 5.0 seconds = 250.800 FPS
1260 frames in 5.0 seconds = 252.000 FPS
1276 frames in 5.0 seconds = 255.200 FPS
1260 frames in 5.0 seconds = 252.000 FPS
1260 frames in 5.0 seconds = 252.000 FPS
1134 frames in 5.0 seconds = 226.800 FPS
1260 frames in 5.0 seconds = 252.000 FPS
1262 frames in 5.0 seconds = 252.400 FPS
1182 frames in 5.0 seconds = 236.400 FPS
1260 frames in 5.0 seconds = 252.000 FPS
1134 frames in 5.0 seconds = 226.800 FPS
1260 frames in 5.0 seconds = 252.000 FPS
X connection to :0.0 broken (explicit kill or server shutdown).

The 2 stumbles visible were probably kmail related.

And the exit message when clicking on it to close it is changed from
the former "Broken pipe" to the above, so there is a side effect of
this 2 line patch observed here.

Humm, another effect I just noticed, tvtime had a just barely
noticeable stutter, frame skips I think, that was much worse when
running the unpatched rc2-mm2. They seem to be gone, its as smooth
as the hubble mirror at the moment.

I don't know what other side efects this particular patch might have
but it sure seems like its all plus for this user.

>Description: Replace MS_TO_HZ() with msecs_to_jiffies().
>
>Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
>
>---
>
> linux-2.6.9-rc2-bk7-max/drivers/video/aty/radeon_base.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
>diff -puN
> drivers/video/aty/radeon_base.c~use-msecs-to-jiffies-drivers_video_
>aty_radeon_base drivers/video/aty/radeon_base.c ---
> linux-2.6.9-rc2-bk7/drivers/video/aty/radeon_base.c~use-msecs-to-ji
>ffies-drivers_video_aty_radeon_base 2004-09-21 20:51:45.000000000
> +0200 +++
> linux-2.6.9-rc2-bk7-max/drivers/video/aty/radeon_base.c 2004-09-21
> 20:51:45.000000000 +0200 @@ -61,6 +61,7 @@
> #include <linux/tty.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
>+#include <linux/time.h>
> #include <linux/fb.h>
> #include <linux/ioport.h>
> #include <linux/init.h>
>@@ -1286,7 +1287,7 @@ static void radeon_write_mode (struct ra
> OUTREG(LVDS_GEN_CNTL, mode->lvds_gen_cntl | LVDS_BLON);
> rinfo->pending_lvds_gen_cntl = mode->lvds_gen_cntl;
> mod_timer(&rinfo->lvds_timer,
>- jiffies + MS_TO_HZ(rinfo->panel_info.pwr_delay));
>+ jiffies + msecs_to_jiffies(rinfo->panel_info.pwr_delay));
> }
> }
> }
>_

Nice catch guys.

--
Cheers, Gene
"There are four boxes to be used in defense of liberty:
soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.26% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.038 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site