Messages in this thread | | | Date | Fri, 24 Sep 2004 14:19:12 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2.6.9-rc2-mm2] Create new function to see if pci dev is present |
| |
On Fri, Sep 24, 2004 at 08:02:31PM +0100, Christoph Hellwig wrote: > On Thu, Sep 23, 2004 at 03:26:40PM -0700, Hanna Linder wrote: > > > > Greg asked in a previous janitors thread: > > "What we need is a simple "Is this pci device present right now" type > > function, to solve the mess that logic like this needs." > > > > OK. How about this one? It uses pci_get_device but instead of returning > > the dev it returns 1 if the device is present and 0 if it isnt. This take the > > burdon off the driver from having to know when to use pci_dev_put or > > not and should be cleaner for future maintenance work. > > > > Ive tested it with two patches that will follow. > > Please include subdevice/subvendor id
Good idea, but do you see any places in the kernel that would use those fields, instead of always setting them to PCI_ANY_ID?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |