lkml.org 
[lkml]   [2004]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][2.6] Add command function to struct i2c_adapter
    On Mon, Sep 20, 2004 at 07:19:24PM +0200, Michael Hunold wrote:
    >
    > + /* a ioctl like command that can be used to perform specific functions
    > + * with the adapter.
    > + */
    > + int (*command)(struct i2c_adapter *adapter, unsigned int cmd, void *arg);

    Ick ick ick. We don't like ioctls for the very reason they aren't type
    safe, and you can pretty much stick anything in there you want. So
    let's not try to add the same type of interface to another subsystem.

    How about we add the exact explicit functionality that you want, one
    function per "type" of operation, like all other subsystems have.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:5.401 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site