lkml.org 
[lkml]   [2004]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Minor IPSec bug + solution
    From
    Date
    On Fri, 2004-09-17 at 12:27, Herbert Xu wrote:
    > On Fri, Sep 17, 2004 at 11:26:13AM +0200, Martin Bouzek wrote:
    > >
    > > > > function. For tunnels it returns
    > > > >
    > > > > tmpl->optional && !xfrm_state_addr_cmp(tmpl, x, family);
    > >
    > > Well, I am not expierienced with the networking kernel code,
    > > nevertheless I still think the check is not correct.
    >
    > If you change the && to ||, then an ESP tunnel SA marked as required
    > can be matched by a simple IPIP SA with the same addresses.

    Ok. And would it be possible to check the protocols too (eg.
    tmpl->id.proto == x->id.proto)? If it is realy not possible to make the
    IPComp/required tunnel to work, it would be nice to mention it in for
    example the setkey man page. It could save quite lot of time to some
    people. (like me :-) ).

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.020 / U:30.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site