lkml.org 
[lkml]   [2004]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: hotplug e1000 failed after 32 times
    From
    Date
    On Sat, 2004-09-18 at 07:34, Jeff Garzik wrote:
    > All this work and code for such an uncommon case??
    >
    > First off, any settings which are _indexed_ are almost guaranteed
    > broken. For reasons as we see here, and others. Any
    > "setting_foo[board_number]" should be found and eliminated instead.
    >
    > Even if you allocate and free board numbers as described, how precisely
    > do you propose to predict which settings belong to which hotplugged
    > board? Look at the problem, and you realize that the board<->setting
    > association becomes effectively _random_ for any adapter not present at
    > modprobe time.
    >
    > The best model is to set these settings via netlink/ethtool after
    > registering the interface, but before bringing it up.
    I'm not familiar with the NIC driver, but this problem really is
    annoying. The gurus, please consider a solution. It's not an uncommon
    case. I believe it's common in a big system with hotplug support. I can
    understand why the driver doesn't support more than 32 a card, but one
    card with 32 times hotplug failed is a little ugly.

    Thanks,
    Shaohua

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:3.640 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site