lkml.org 
[lkml]   [2004]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 1/6] xattr consolidation v2 - generic xattr API
    Date
    Hello,

    the patches look good except for a theoretical race in generic_listxattr:

    > +ssize_t generic_listxattr(struct dentry *dentry, char *buffer, size_t
    > buffer_size) +{
    > + struct inode *inode = dentry->d_inode;
    > + struct xattr_handler *handler, **handlers = inode->i_sb->s_xattr;
    > + unsigned int size = 0;
    > + char *buf;
    > +
    > + for_each_xattr_handler(handlers, handler)
    > + size += handler->list(inode, NULL, NULL, 0);

    We might setxattr here and the name list might change between the two passes.

    > [...]
    > + for_each_xattr_handler(handlers, handler)
    > + buf += handler->list(inode, buf, NULL, 0);
    > +
    > + return size;
    > +}

    This currently is only relevant for the security attribute. Selinux always
    returns the same attribute name so it can't trigger this problem, but other
    LSMs might do something different.

    We can add a list_size parameter to xattr_handler->list to get this fixed. We
    should change the name_len parameter of xattr_handler->list from int to
    size_t:

    Index: linux-2.6.9-rc1/include/linux/xattr.h
    ===================================================================
    --- linux-2.6.9-rc1.orig/include/linux/xattr.h
    +++ linux-2.6.9-rc1/include/linux/xattr.h
    @@ -17,8 +17,8 @@

    struct xattr_handler {
    char *prefix;
    - size_t (*list)(struct inode *inode, char *list, const char *name,
    - int name_len);
    + size_t (*list)(struct inode *inode, char *list, size_t list_size,
    + const char *name, size_t name_len);
    int (*get)(struct inode *inode, const char *name, void *buffer,
    size_t size);
    int (*set)(struct inode *inode, const char *name, const void *buffer,
    Index: linux-2.6.9-rc1/fs/xattr.c
    ===================================================================
    --- linux-2.6.9-rc1.orig/fs/xattr.c
    +++ linux-2.6.9-rc1/fs/xattr.c
    @@ -397,23 +397,22 @@ ssize_t generic_listxattr(struct dentry
    struct inode *inode = dentry->d_inode;
    struct xattr_handler *handler, **handlers = inode->i_sb->s_xattr;
    unsigned int size = 0;
    - char *buf;
    -
    - for_each_xattr_handler(handlers, handler)
    - size += handler->list(inode, NULL, NULL, 0);
    -
    - if (!buffer)
    - return size;
    -
    - if (size > buffer_size)
    - return -ERANGE;
    -
    - buf = buffer;
    - handlers = inode->i_sb->s_xattr;
    -
    - for_each_xattr_handler(handlers, handler)
    - buf += handler->list(inode, buf, NULL, 0);

    + if (!buffer) {
    + for_each_xattr_handler(handlers, handler)
    + size += handler->list(inode, NULL, 0, NULL, 0);
    + } else {
    + char *buf = buffer;
    +
    + for_each_xattr_handler(handlers, handler) {
    + size = handler->list(inode, buf, buffer_size, NULL, 0);
    + if (size > buffer_size)
    + return -ERANGE;
    + buf += size;
    + buffer_size -= size;
    + }
    + size = buf - buffer;
    + }
    return size;
    }

    The current users can easily be converted. As a side effect, the
    ext2_xattr_list() and ext3_xattr_list() functions could also be changed to do
    a single iteration only.
    I also noticed that your additions to fs/xattr.c use a slightly different
    coding style than the rest of the file. You might want to change that as
    well.

    Cheers,
    --
    Andreas Gruenbacher <agruen@suse.de>
    SUSE Labs, SUSE LINUX AG
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.024 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site