Messages in this thread Patch in this message | | | Date | Tue, 14 Sep 2004 02:34:15 -0700 | From | William Lee Irwin III <> | Subject | [printk] make console_conditional_schedule() __sched and use cond_resched() |
| |
On Tue, Sep 14, 2004 at 11:15:29AM +0200, Ingo Molnar wrote: > the attached patch is ontop of preempt-smp.patch. This is another > generic fallout from the voluntary-preempt patchset: a cleanup of the > cond_resched() infrastructure, in preparation of the latency reduction > patches. The changes:
Relatively minor add-on (not necessarily tied to it or required to be taken or a fix for any bug). Since cond_resched() is using PREEMPT_ACTIVE now, it may be useful to update the open-coded instance of cond_resched() to use the generic call. Also, it should probably be __sched so the caller shows up in wchan.
-- wli
Index: mm5-2.6.9-rc1/kernel/printk.c =================================================================== --- mm5-2.6.9-rc1.orig/kernel/printk.c 2004-08-24 01:13:48.000000000 -0700 +++ mm5-2.6.9-rc1/kernel/printk.c 2004-09-14 02:23:41.222204160 -0700 @@ -658,12 +658,10 @@ * * Must be called within acquire_console_sem(). */ -void console_conditional_schedule(void) +void __sched console_conditional_schedule(void) { - if (console_may_schedule && need_resched()) { - set_current_state(TASK_RUNNING); - schedule(); - } + if (console_may_schedule) + cond_resched(); } EXPORT_SYMBOL(console_conditional_schedule); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |