Messages in this thread | | | Date | Mon, 13 Sep 2004 15:25:30 +0200 (CEST) | From | Roman Zippel <> | Subject | Re: 2.6.9-rc1-mm4 sparc reiser4 build broken - undefined atomic_sub_and_test |
| |
Hi,
On Mon, 13 Sep 2004, Hugh Dickins wrote:
> But Bill already said he doesn't want it, [...] > > - if (atomic_sub_and_test(bio->bi_vcnt, &fq->nr_submitted)) > + if (atomic_sub_return(bio->bi_vcnt, &fq->nr_submitted) == 0)
And that is more portable how? atomic_sub_and_test() allows some archs to generate better code and the rest can still fall back to atomic_sub_return. (Maybe it's time for <linux/atomic.h>/ <asm-generic/atomic.h>?)
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |