Messages in this thread | | | Date | Mon, 13 Sep 2004 12:41:12 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [RFC][PATCH] Put size in array to get rid of barriers in grow_ary() |
| |
On Fri, 10 Sep 2004, Paul E. McKenney wrote: > On Wed, Sep 08, 2004 at 03:07:53PM -0700, Paul E. McKenney wrote: > > On Wed, Sep 08, 2004 at 04:39:43PM +0100, Hugh Dickins wrote: > > > Wouldn't it be a little nicer to start ipc_ids off pointing to a > > > const ipc_id_ary of size 0, to avoid the various entries == NULL > > > tests you had to add? > > > > I like this one!!! Will put a patch together. Manfred's recent > > patch applied a refcount, which negates the const part, but should > > be no problem to put a size-zero structure in the struct ipc_ids. > > (Having a separately allocated structure puts me back to checking > > NULL pointers due to possibility of allocation failure.) > > And here, finally, is the updated patch. Still untested.
That looks good, Paul, thank you. (But I too have not tested.)
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |