lkml.org 
[lkml]   [2004]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]: Re: kernel 2.6.9-rc1-mm4 oops
    On Mon, Sep 13, 2004 at 12:06:39PM +0400, Kirill Korotaev wrote:
    > --- ./kernel/exit.c.nt 2004-09-13 11:18:26.000000000 +0400
    > +++ ./kernel/exit.c 2004-09-13 11:53:23.611075360 +0400
    > @@ -848,10 +848,7 @@ asmlinkage long sys_exit(int error_code)
    > task_t fastcall *next_thread(const task_t *p)
    > {
    > #ifdef CONFIG_SMP
    > - if (!p->sighand)
    > - BUG();
    > - if (!spin_is_locked(&p->sighand->siglock) &&
    > - !rwlock_is_locked(&tasklist_lock))
    > + if (!rwlock_is_locked(&tasklist_lock))
    > BUG();
    > #endif
    > return pid_task(p->pids[PIDTYPE_TGID].pid_list.next, PIDTYPE_TGID);

    Hmm, BUG_ON() for whatever users (embedded?) that define BUG()/BUG_ON()
    checks to nops may be useful here since no side effects are expected
    from rwlock_is_locked().

    FWIW I got this once while running initscripts(!) on a 4x logical x86-64
    on virgin 2.6.9-rc1-mm4 but couldn't reproduce it.


    -- wli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.022 / U:1.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site