Messages in this thread | | | From | BlaisorBlade <> | Subject | Re: [uml-devel] [PATCH] nptl/sys_clone fix for i386/ppc | Date | Mon, 13 Sep 2004 20:50:08 +0200 |
| |
On Monday 13 September 2004 05:10, Jeff Dike wrote: > On Sun, Sep 12, 2004 at 05:52:44PM +0200, BlaisorBlade wrote: > > It worked no worse than current version (which is broken). In fact the > > 2.4 clone had 2 arguments. So it's obvious. > > In fact, it worked better. It worked on a modern Debian filesystem, where > my old code didn't. Oh, well, your version gets the fifth arg right, indeed. > > However, this is non-standard. I've added just a comment for now, since > > you may have reason to keep the current code, but such behaviour calls > > for breakage when things change.
> Yeah, I not sure why I did things the way I did. That's very old code, and > there may have been some good reason for it which has since disappeared.
> Offhand, it looks like doing things in the standard way will clean up > copy_thread a bit. I agree completely. -- Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |