lkml.org 
[lkml]   [2004]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Add sparse "__iomem" infrastructure to check PCI address usage

    While resuming adding __user annotations to the m68k-specific parts of the
    code, I stumbled on

    struct task_struct {
    ...
    unsigned long sas_ss_sp;
    ...
    }

    If I'm not mistaken, sas_ss_sp is always a pointer to user stack space.
    Shouldn't it be changed to `void __user *sas_ss_sp', or is an
    unsigned long/void * change in generic code a too controversial change for
    making sparse happy?

    And I guess I can find a few more of these...

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.026 / U:61.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site