Messages in this thread | | | Date | Sat, 11 Sep 2004 18:57:26 +0100 | From | Luke Kenneth Casson Leighton <> | Subject | Re: [PATCH 2.6 NETFILTER] new netfilter module ipt_program.c |
| |
On Sat, Sep 11, 2004 at 04:36:14PM +0200, Patrick McHardy wrote: > Luke Kenneth Casson Leighton wrote: > >On Sat, Sep 11, 2004 at 02:29:35PM +0100, Luke Kenneth Casson Leighton > >wrote: > > > > thing is, you see, i know just enough to be dangerous. > > > > using files->file_lock a) seems to work b) is accepted code in the > > kernel. > > It seems to work - on UP where it is a NOP. On SMP it will deadlock. > That we have some broken code doesn't mean we want more of it :)
*cackle*
> > if someone else has the experience and knowledge to fix ipt_owner.c > > i'll quite happily cut/paste that instead - once it's fixed. > > The "fix" is quite easy, replace all occurences of > spin_lock(&files->file_lock) in the kernel by spin_lock_bh.
> But that's not going to be accepted.
's'just'a'big'job'for "replace", innit?
[btw _what_ is the "replace" command doing in the debian mysql package??]
> IIRC the SELinux guys > want to label packets with the name of the sending process, > maybe we can use this for the owner match once it's done.
... well, given that i'll be rolling this out (broken or not) on a single-processor SELinux system, whatever is added [for selinux] would also need to be useable by thingy. ipt_owner.c. as well.
l.
-- -- Truth, honesty and respect are rare commodities that all spring from the same well: Love. If you love yourself and everyone and everything around you, funnily and coincidentally enough, life gets a lot better. -- <a href="http://lkcl.net"> lkcl.net </a> <br /> <a href="mailto:lkcl@lkcl.net"> lkcl@lkcl.net </a> <br />
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |