Messages in this thread | | | Date | Wed, 1 Sep 2004 16:27:56 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] fs/compat.c: rwsem instead of BKL around ioctl32_hash_table |
| |
Roland Dreier <roland@topspin.com> wrote: > > Currently the BKL is used to synchronize access to ioctl32_hash_table > in fs/compat.c. It seems that an rwsem would be more appropriate, > since this would allow multiple lookups to occur in parallel (and also > serve the general good of minimizing use of the BKL).
It introduces additional bus-atomic operations into the fastpath, so we'll be slower in the one-process-doing-lots-of ioctls case, and faster in the lots-of-cpus-doing-ioctls case.
The change certainly makes sense from a clean-things-up and prepare-for-bkl-removal point of view, however.
Some single-threaded and multi-threaded SMP microbenchmarking would be nice, if you have time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |