Messages in this thread Patch in this message | | | Date | Wed, 1 Sep 2004 16:51:22 +0100 | From | Dave Jones <> | Subject | [PATCH] Remove pointless check in zlib |
| |
We dereference 'z' a few lines above this check. If it was possible to hit this condition, it wouldve triggered long ago, in the form of a crash.
Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/lib/zlib_inflate/inflate.c linux-2.6/lib/zlib_inflate/inflate.c --- bk-linus/lib/zlib_inflate/inflate.c 2004-06-03 13:40:26.000000000 +0100 +++ linux-2.6/lib/zlib_inflate/inflate.c 2004-06-03 13:42:54.000000000 +0100 @@ -53,8 +53,6 @@ int zlib_inflateInit2_( return Z_VERSION_ERROR; /* initialize state */ - if (z == NULL) - return Z_STREAM_ERROR; z->msg = NULL; z->state = &WS(z)->internal_state; z->state->blocks = NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |