lkml.org 
[lkml]   [2004]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] announce hpet devices claimed
Date
I think the HPET driver should announce the hardware it claims.  Here's
a patch that prints this:

hpet0: at MMIO 0xc0000ffffc002000, IRQs 74, 75, 76
hpet0: 4ns tick, 3 64-bit timers
hpet1: at MMIO 0xc0000ffffc082000, IRQs 77, 78, 79
hpet1: 4ns tick, 3 64-bit timers

This has been acked by Bob. I haven't heard from Venkatesh.


Print basic information (MMIO address, IRQs used, tick rate, number
of timers) when claiming an HPET device.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

===== drivers/char/hpet.c 1.5 vs edited =====
--- 1.5/drivers/char/hpet.c 2004-08-02 02:00:44 -06:00
+++ edited/drivers/char/hpet.c 2004-08-26 12:46:01 -06:00
@@ -789,6 +789,7 @@
size_t siz;
struct hpet *hpet;
static struct hpets *last __initdata = (struct hpets *)0;
+ unsigned long ns;

/*
* hpet_alloc can be called by platform dependent code.
@@ -840,6 +841,18 @@
hpetp->hp_period = (cap & HPET_COUNTER_CLK_PERIOD_MASK) >>
HPET_COUNTER_CLK_PERIOD_SHIFT;

+ printk(KERN_INFO "hpet%d: at MMIO 0x%p, IRQ%s",
+ hpetp->hp_which, hpet, hpetp->hp_ntimer > 1 ? "s" : "");
+ for (i = 0; i < hpetp->hp_ntimer; i++)
+ printk("%s %d", i > 0 ? "," : "", hdp->hd_irq[i]);
+ printk("\n");
+
+ ns = hpetp->hp_period; /* femptoseconds, 10^-15 */
+ do_div(ns, 1000000); /* convert to nanoseconds, 10^-9 */
+ printk(KERN_INFO "hpet%d: %ldns tick, %d %d-bit timers\n",
+ hpetp->hp_which, ns, hpetp->hp_ntimer,
+ cap & HPET_COUNTER_SIZE_MASK ? 64 : 32);
+
mcfg = readq(&hpet->hpet_config);
if ((mcfg & HPET_ENABLE_CNF_MASK) == 0) {
write_counter(0L, &hpet->hpet_mc);
@@ -946,7 +960,6 @@

static struct acpi_driver hpet_acpi_driver __initdata = {
.name = "hpet",
- .class = "",
.ids = "PNP0103",
.ops = {
.add = hpet_acpi_add,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.029 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site