lkml.org 
[lkml]   [2004]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] obscure pid implementation fix (v2)
    On Wed, Sep 01, 2004 at 03:46:07PM +0400, Kirill Korotaev wrote:
    >> I remade the previous patch against the latest Linus tree, please apply.
    >> This patch fixes strange and obscure pid implementation in current kernels:
    >> - it removes calling of put_task_struct() from detach_pid()
    >> under tasklist_lock. This allows to use blocking calls
    >> in security_task_free() hooks (in __put_task_struct()).
    >> - it saves some space = 5*5 ints = 100 bytes in task_struct
    >> - it's smaller and tidy, more straigthforward and doesn't use
    >> any knowledge about pids using and assignment.
    >> - it removes pid_links and pid_struct doesn't hold reference counters
    >> on task_struct. instead, new pid_structs and linked altogether and
    >> only one of them is inserted in hash_list.
    >> Signed-off-by: Kirill Korotaev (kksx@mail.ru)

    On Wed, Sep 01, 2004 at 08:36:24AM -0700, William Lee Irwin III wrote:
    > Could you not rename struct pid and not rename for_each_task_pid()?

    And not rename ->hash_chain.

    Thanks.


    -- wli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.022 / U:30.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site