Messages in this thread | | | Date | Sun, 8 Aug 2004 12:25:12 +0200 | Subject | Re: [PATCH][RESENT] remove hardcoded offsets from ppc asm | From | Vincent Hanquez <> |
| |
On Sun, Aug 08, 2004 at 09:32:12AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2004-08-08 at 01:18, Vincent Hanquez wrote: > > Hi LKML, > > > > This patch removes hardcoded offsets from ppc asm. > > It generate offsets for thread_info structure instead of hardcoding them. > > > > Please apply or comments, > > > > Signed-off-by: Vincent Hanquez <tab@snarc.org> > > I have nothing against the idea, but why the hell did you change the > constant names, turning them partially to lowercase ? They are just > fine beeing uppercase, this is more consistent, and that would > reduce the size of your patch signficantly.
Hi Benjamin, it seems to be the 'convention'. I did the same comment some time ago to Brian Gerst with his patch for i386.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108454158825656&w=2
But if you prefer a smaller patch, without changing the constant name, I can do that too.
Sorry about the first set of patch, I didn't see your reply. I just saw it today on the archive.
-- Tab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |