Messages in this thread | | | Date | Sat, 7 Aug 2004 00:37:31 +0200 | From | Pavel Machek <> | Subject | Re: Solving suspend-level confusion |
| |
Hi!
> > > Very easy... with the current code, just use state 4 for the round > > > of suspend callbacks, ide-disk will then avoid spinning down. > > > > There are some network drivers that test for "4" and fails suspend > > with something like "invalid suspend state" :-(. > > Easily fixed. Again, i'm not afraid of fixing driver, few enough of > them care at all at this point. I'll send some patches this week-end > to patrick for his bk tree adding the basic ppc support and renumbering > the PM callbacks, I havne't changed the type yet though, that's a more > tedious work and I'm a lazy guy ;)
Well, changing "int" to "enum something" as you go might serve you as "I've already fixed this one" marker ;-). And as it does not even create a warning, it might be feasible to do incrementally...
Or even typedef suspend_state_t u32...
Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |