lkml.org 
[lkml]   [2004]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix argument checking in sched_setaffinity
    Looks good - thanks, Andi.

    I notice that you didn't bother with the fractional byte that is handled
    by 'endmask' in mm/mempolicy.c:get_nodes(). But I really don't give a
    hoot - either way is fine by me.

    I've written a couple of code snippets that manage to intuit the size of
    the kernel's cpumask dynamically from user space, by probing with
    various sched_getaffinity() calls. But since your patch only changes
    the errors generated by sched_setaffinity() [that's "set", not "get"], I
    will not experience any grief from this subtle change in the kernel's
    API.

    Should you lock hotplug before calling get_user_cpu_mask(), since
    get_user_cpu_mask() depends on cpu_online_mask()?

    --
    I won't rest till it's the best ...
    Programmer, Linux Scalability
    Paul Jackson <pj@sgi.com> 1.650.933.1373
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.020 / U:30.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site