Messages in this thread |  | | | Date | Tue, 31 Aug 2004 18:36:55 -0700 | | From | Paul Jackson <> | | Subject | Re: [PATCH] Fix argument checking in sched_setaffinity |
| |
Looks good - thanks, Andi.
I notice that you didn't bother with the fractional byte that is handled by 'endmask' in mm/mempolicy.c:get_nodes(). But I really don't give a hoot - either way is fine by me.
I've written a couple of code snippets that manage to intuit the size of the kernel's cpumask dynamically from user space, by probing with various sched_getaffinity() calls. But since your patch only changes the errors generated by sched_setaffinity() [that's "set", not "get"], I will not experience any grief from this subtle change in the kernel's API.
Should you lock hotplug before calling get_user_cpu_mask(), since get_user_cpu_mask() depends on cpu_online_mask()?
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.650.933.1373 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |