lkml.org 
[lkml]   [2004]   [Aug]   [31]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 31 Aug 2004 00:59:08 -0400
FromDaniel Jacobowitz <>
SubjectRe: [PATCH] cleanup ptrace stops and remove notify_parent
On Mon, Aug 30, 2004 at 09:55:30PM -0700, Roland McGrath wrote:
> > Unless it's been changed since I last pulled, you should also fix up
> > has_stopped_jobs.  I think it's broken by the introduction of
> > TASK_TRACED.
> 
> Actually, I don't think it was broken at all.  It has an old kludge to
> avoid considering trace-stopped threads as stopped for purposes of deciding
> to generate signals for an orphaned process group.  I think that the useful
> thing is for it not to consider any TASK_TRACED thread as stopped here either.
> That's what it will already do, and the old kludge can go now:

[The kludge isn't all that old.  I added it about a year and a half
ago.]

You're right.  I misread the loop.  It's still only an approximation,
in that we don't know what the debugger's intention towards resuming
the program is, but I think we err on the correct side now.

-- 
Daniel Jacobowitz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [from the cache]
©2003-2008