Messages in this thread Patch in this message | | | From | Tim Fairchild <> | Subject | Re: K3b and 2.6.9? | Date | Tue, 31 Aug 2004 11:51:25 +1000 |
| |
On Monday 30 Aug 2004 23:07, Alan Cox wrote:
> Folks are working on getting the verify_command list refined, or you > can run the burner part of cd-burners setuid (as cdrecord supports - > although get the newest one since there was a security hole fixed a few > days ago in both cdrecord and star). > > > Without knowing a better way, I am currently using the same sort of quick > > patch as 2.6.8.1 to use k3b on 2.6.9-rc1-bk5 ie: > > Providing you don't mind any of your users erasing your drive firmware > and turning the drive into a brick its fine.
Thanks. Yes I realize that and understand why this is a good idea to have. But most of the verify_command list seems fine and I find the following works, but don't know if this is any 'safer' or not... This is the particular test that makes the difference to k3b/cdrecord, but I don't know enough to work out what it actually does... (this is with 2.6.9-rc1-bk6)
--- a/drivers/block/scsi_ioctl.c.original 2004-08-30 23:50:16.000000000 +1000 +++ b/drivers/block/scsi_ioctl.c 2004-08-31 08:37:56.000000000 +1000 @@ -192,7 +192,7 @@
/* Write-safe commands just require a writable open.. */ if (type & CMD_WRITE_SAFE) { - if (file->f_mode & FMODE_WRITE) +/* if (file->f_mode & FMODE_WRITE) */ return 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |