Messages in this thread | | | Subject | Re: SMP Panic caused by [PATCH] sched: consolidate sched domains | From | James Bottomley <> | Date | 29 Aug 2004 12:58:22 -0400 |
| |
On Sun, 2004-08-29 at 12:48, Jesse Barnes wrote: > But I think this breaks what the code is supposed to do. You're right that we > shouldn't use cpu_online_map, but we should leave the nodemask in there and > fix the code that sets it in the non-NUMA case instead.
Well, let's say it puts back the original behaviour. If you look at even the NUMA code before these changes, it had cpu_possible_map in there.
I totally agree about fixing NUMA, it looks completely broken to me in the way it handles cpu maps because node_to_cpumask(i) needs to expand to cpu_possible_map for initialisation and cpu_online_map for operation. Has anyone ever checked NUMA for hotplug CPU?
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |