Messages in this thread | | | Date | Sat, 28 Aug 2004 15:37:28 -0700 | From | Andrew Morton <> | Subject | Re: [4/5] eliminate bh waitqueue hashtable |
| |
William Lee Irwin III <wli@holomorphy.com> wrote: > > +static inline int wait_on_bit(void *word, int bit, > + int (*action)(void *), unsigned mode) > +{ > + DEFINE_WAIT_BIT(q, word, bit); > + wait_queue_head_t *wqh; > + > + if (!test_bit(bit, word)) > + return 0; > + > + wqh = bit_waitqueue(word, bit); > + return __wait_on_bit(wqh, &q, word, bit, action, mode); > +}
This is still all inlined. Given that we're going to schedule away, don't you think we should out-of-line the slowpath? As I said yesterday:
static inline int wait_on_bit(...) { if (test_bit(...)) return out_of_line_wait_on_bit(...); return 0; }
I merged this latest batch into -mm. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |