Messages in this thread | | | Date | Mon, 23 Aug 2004 13:18:58 -0500 | From | Dave C Boutcher <> | Subject | Re: [PATCH] ppc64 mf_proc file position fix |
| |
On Mon, Aug 23, 2004 at 06:54:23PM +0100, Christoph Hellwig wrote: > On Fri, Aug 20, 2004 at 03:10:32PM -0500, Dave C Boutcher wrote: > > Andrew, > > > > arch/ppc64/kernel/mf_proc.c uses a bad interface for moving > > along file position in a proc_write routine. This quit working > > altogether in 2.6.8. Patch to fix. And I did a quick scan of the > > kernel to see if anyone else was similarly broken...apparantly not :-) > > > > Fixes a broken update of f_pos in a proc file write routine. > > What about moving on to seq_file while you're at it? Switching from > one deprecated interface to another doesn't really sound like a worthwile > effort.
The specific problem was on the write side, not the read side, so AFAIK, seq_file wasn't going to help out. I started re-writing the whole file to use seq_file for all the read stuff, and after a few hours into it I decided to just fix the broken bit rather than gratuitously rewriting the whole thing.
-- Dave Boutcher - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |