lkml.org 
[lkml]   [2004]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH][2.6] Hotplug cpu: Fix APIC queued timer vector race
    From
    Date
    On Sun, 2004-08-22 at 00:10, Zwane Mwaikambo wrote:
    > Some timer interrupt vectors were queued on the Local APIC and were being
    > serviced when we enabled interrupts again in fixup_irqs(), so we need to
    > mask the APIC timer, enable interrupts so that any queued interrupts get
    > processed whilst the processor is still on the online map and then clear
    > ourselves from the online map. 1ms is a nice safe number even under heavy
    > interrupt load with higher priority vectors queued. Andrew this is
    > the patch i promised, Rusty, i'm not sure if you find
    > __attribute__((weak)) offensive...

    It's horrible. Please move the unsetting of the cpu_online bit into the
    arch-specific __cpu_disable() code for each arch, which is consistent
    and also simplifies things.

    Thanks,
    Rusty.
    --
    Anyone who quotes me in their signature is an idiot -- Rusty Russell

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.023 / U:32.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site