Messages in this thread Patch in this message | | | From | Stefan Seyfried <> | Subject | swsusp: avoid emergency disk parking in "platform" mode | Date | Fri, 20 Aug 2004 09:50:37 +0200 |
| |
Hi,
although the issue seems fixed on normal shutdown and with swsusp in "shutdown" mode, i still get the ugly "clunk" of my emergency-parking disk in platform mode. The attached patch fixes this for me, although i am not sure this is the correct way to do. Probably some device_suspend(SOMETHING) would be better and maybe the device_power_down is no longer needed, but something needs to be done at this point.
Stefan diff -ru --exclude '*.o' linux-orig/kernel/power/disk.c linux/kernel/power/disk.c --- linux-orig/kernel/power/disk.c 2004-08-17 19:56:33.000000000 +0200 +++ linux/kernel/power/disk.c 2004-08-20 09:40:40.581304056 +0200 @@ -49,6 +49,7 @@ local_irq_save(flags); switch(mode) { case PM_DISK_PLATFORM: + device_shutdown(); device_power_down(PM_SUSPEND_DISK); error = pm_ops->enter(PM_SUSPEND_DISK); break; | |