Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [ACPI] Re: [PATCH] cleanup ACPI numa warnings | Date | Fri, 20 Aug 2004 15:22:41 -0400 |
| |
On Friday, August 20, 2004 2:55 pm, Alex Williamson wrote: > I'm not sure where we stand on this, sorry for the delay. To recap, > the first patch I submitted cleaned up the original functions, but moved > the ugliness up into multi-line macros. People didn't like the macros > and suggested static inlines. However, static inlines don't work for > this application because the debug print needs state setup by the > ACPI_FUNCTION_NAME call. IMHO, it's not worth setting up that state in > the static inline function for this little bit of cleanup. > > So, I think we left it at nobody liked the macros and static inlines > don't work. General unhappiness. Below is a patch that doesn't attempt > to cleanup the original code, it just adds the #ifdefs and range > checking w/ no macros. Does this look better? Below is the original > submit comment outlining the goal. Thanks,
Yes please.
Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |