Messages in this thread | | | Subject | Re: [UPDATED PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code | From | Rusty Russell <> | Date | Tue, 03 Aug 2004 10:27:41 +1000 |
| |
On Tue, 2004-08-03 at 07:47, Dominik Brodowski wrote: > Thanks for your feedback, Rusty.
Hey, thanks for the code!
> > > +/* Needs to be before __initcall(module_init) */ > > > +fs_initcall(param_sysfs_init); > > > > That's horrible. And I think the initcall in module.c should be removed > > in your second patch, no? > > Actually, it could have remained __initcall... and the one in module.c is > needed as we still register a module subsystem. This updated patch doesn't > add an own initcall in params.c, though, but rather param_sysfs_init() gets > called by module_init.
It's logically separate, IMHO. I'm thinking about CONFIG_MODULES=n here...
Cheers, Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |