Messages in this thread Patch in this message |  | | | Date | Thu, 19 Aug 2004 17:17:29 -0300 | | From | Marcelo Tosatti <> | | Subject | filemap_fdatawait() wait_on_page_writeback_range(mapping, 0, -1)? |
| |
Hi Andrew,
I dont understand why we do call wait_on_page_writeback_range() with -1 as the "end" argument.
Is there a good reason for that? I bet so...
-1 sounds pretty stupid at first, it does unnecessary calls to the radix lookup code.
--- a/mm/filemap.c.orig 2004-08-19 14:36:02.000000000 -0300 +++ b/mm/filemap.c.isize 2004-08-19 18:17:14.000000000 -0300 @@ -231,7 +231,7 @@ */ int filemap_fdatawait(struct address_space *mapping) - return wait_on_page_writeback_range(mapping, 0, -1); + return wait_on_page_writeback_range(mapping, 0, i_size_read(mapping->host)); } EXPORT_SYMBOL(filemap_fdatawait); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |