lkml.org 
[lkml]   [2004]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.4.27 - MTD cfi_cmdset_0002.c - Duplicate cleanup in error path

    Applied Rainer's patch, its equivalent and I his
    "consisteny with other algorithms" point is a good one.

    Thanks guys!

    On Sat, Jul 24, 2004 at 03:14:03PM +0800, Rainer Weikusat wrote:
    > "bradgoodman.com" <bkgoodman@bradgoodman.com> writes:
    > > Patch to 2.4.x: Corrects an obvious error where all of the cleanups are done
    > > twice in the event of a chip programming error. This can result in
    > > kernel BUG() getting called on subsequent programming attempts.
    <snip>
    > That way, it is consistent with the other low-level chip access
    > functions. But the algorithm is per se buggy, anyway, because except
    > if DQ5 was raised before, the chip is not 'ready' (for reading array
    > data), but still in programming mode and will remain there until the
    > 'embedded programming algorithm' stops, because (according to the
    > docs) a reset command will not be accepted until DQ5 has been raised
    > and the opportunityto check for that is gone after the syscall
    > returned to the caller.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.022 / U:59.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site