Messages in this thread |  | | | From | Oliver Neukum <> | | Subject | Re: Add msleep_interruptible() function to kernel/timer.c | | Date | Sun, 15 Aug 2004 14:50:35 +0200 |
| |
Am Sonntag, 15. August 2004 14:18 schrieb maximilian attems: > while doing kernel-janitor msleep conversion of drivers own (incorrect), > functions, some places would need msleep_interruptible(). > > this function is equivalent to: > current->state = TASK_INTERRUPTIBLE; > schedule_timeout(timeout); > > idea from Ingo Molnar: > well, aboves is not 100% equivalent because msleep() is uninterruptible so > stoppage of the md thread (upon shutdown) will occur with only a 250 msec > delay. Someone should add a msleep_interruptible() function to kernel/timer.c.
[..] > +/** > + * msleep_interruptible - sleep waiting for waitqueue interruptions > + * @msecs: Time in milliseconds to sleep for > + */ > +void msleep_interruptible(unsigned int msecs) > +{ > + unsigned long timeout = msecs_to_jiffies(msecs); > + > + while (timeout) { > + set_current_state(TASK_INTERRUPTIBLE); > + timeout = schedule_timeout(timeout); > + }
This is not really interruptible sleep because it is missing a check for pending signals.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |