Messages in this thread | | | Date | Fri, 13 Aug 2004 13:12:36 +0100 | From | Russell King <> | Subject | Re: [2.6 patch] let W1 select NET |
| |
On Fri, Aug 13, 2004 at 01:01:37PM +0200, Adrian Bunk wrote: > On Fri, Aug 13, 2004 at 12:54:25PM +0200, Roman Zippel wrote: > > Hi, > > > > On Fri, 13 Aug 2004, Evgeniy Polyakov wrote: > > > > > On Fri, 2004-08-13 at 14:32, Roman Zippel wrote: > > > > Hi, > > > > > > > > On Fri, 13 Aug 2004, Adrian Bunk wrote: > > > > > > > > > config W1 > > > > > tristate "Dallas's 1-wire support" > > > > > + select NET > > > > > > > > What's wrong with a simple dependency? > > > > > > W1 requires NET, and thus depends on it. > > > If you _do_ want W1 then you _do_ need network and then NET must be > > > selected. > > > > A simple "depends on NET" does this as well, I see no reason to abuse > > select. > > In the case of NET the discussion is mostly hypothetically since nearly > everyone has enabled NET.
In which case, can we remove the user-visibility of CONFIG_NET and instead make all the protocols automatically select it.
I find the over-use of "select" distasteful, and produces a counter- intuitive configuration system. I'll carry on complaining each time I see a patch on LKML which introduces yet another over-use of this feature without properly considering the consequences of doing so.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |