Messages in this thread | | | Date | Thu, 12 Aug 2004 07:01:36 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH]: __crc_* symbols in System.map |
| |
On Wed, Aug 11, 2004 at 08:55:29PM -0700, David S. Miller wrote: > > Shouldn't we be grepping these things out of the System.map file? > > For one thing, these can confuse readprofile. It's algorithm is > to start at _stext, then stop when it sees a line in the System.map > which is not text (mode is one of 'T' 't' 'W' or 'w') > > It will exit early if there are some intermixed __crc_* things in > there (since they are are mode 'A'). > > For example, in my current sparc64 kernel I have this: > > 00000000004cef80 t do_split > 00000000004cf2a0 t add_dirent_to_buf > 00000000004cf5a7 A __crc_init_special_inode > 00000000004cf640 t make_indexed_dir > 00000000004cf900 t ext3_add_entry > > So no symbols after add_dirent_to_buf will be shown in the profiling > output of readprofile. > > So we should grep them out, right? If so, here is a patch which > implements that.
I have a patch in this area pending, it moves System.map generation out of the top-level makefile. And btw simplifies the expression a bit.
iMy patches are only at linux-sam.bkbits.net/kbuild for now, will post patches later this week.
Would it be an option to skip all 'A' symbols?
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |