Messages in this thread | | | Date | Wed, 11 Aug 2004 23:50:47 -0700 | From | William Lee Irwin III <> | Subject | Re: [PATCH 3/3] 2.6.8-rc4-mm1 - UML fixes |
| |
wli@holomorphy.com said: >> Out of curiosity, why are you allocating 4*PAGE_SIZE for the stack if >> you're only going to use 2*PAGE_SIZE of it? I saw no other users for >> the rest of ->thread_info offhand.
On Thu, Aug 12, 2004 at 01:41:18AM -0400, Jeff Dike wrote: > Well, that's slightly misleading. The other two pages (minus the thread_info) > are available for stack if needed. UML stacks are somewhat larger than the > native kernel stacks because of the userspace signal frames, so I allocate > 4 pages for now to be safe.
This might confuse CONFIG_DEBUG_PAGEALLOC, which uses THREAD_SIZE to detect the end of the kernel stack in store_stackinfo() in mm/slab.c and kstack_end() in include/linux/sched.h, and the sizing heuristic for max_threads in fork_init().
Also, how is this meant to interoperate with CONFIG_KERNEL_STACK_ORDER? It seems to ignore the setting from the config option.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |