Messages in this thread | | | Date | Wed, 11 Aug 2004 20:30:12 -0700 | From | William Lee Irwin III <> | Subject | Re: [PATCH 3/3] 2.6.8-rc4-mm1 - UML fixes |
| |
On Thu, Aug 12, 2004 at 12:15:32AM -0400, Jeff Dike wrote: > The patch below fixes a few UML-specific bugs not related to the rest of the > kernel > a bogus error return and some formatting in the fork code > correct calculation of task.thread.kernel_stack > remove a bogus panic > a couple of fixes to allow UML to boot in the presence of exec-shield [...] > p->thread.kernel_stack = > - (unsigned long) p->thread_info + THREAD_SIZE; > + (unsigned long) p->thread_info + 2 * PAGE_SIZE; > return(CHOOSE_MODE_PROC(copy_thread_tt, copy_thread_skas, nr, > clone_flags, sp, stack_top, p, regs));
Out of curiosity, why are you allocating 4*PAGE_SIZE for the stack if you're only going to use 2*PAGE_SIZE of it? I saw no other users for the rest of ->thread_info offhand.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |