Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] add PCI ROMs to sysfs | Date | Wed, 11 Aug 2004 11:02:10 -0700 |
| |
On Wednesday, August 11, 2004 10:28 am, Greg KH wrote: > On Wed, Aug 11, 2004 at 10:04:02AM -0700, Jesse Barnes wrote: > > On Friday, August 6, 2004 2:14 pm, Jon Smirl wrote: > > > Please check the code out and give it some testing. It will probably > > > needs some adjustment for other platforms. > > > > Jon, this works on my machine too. Greg, if it looks ok can you pull it > > in? And can you add: > > > > * (C) Copyright 2004 Silicon Graphics, Inc. > > * Jesse Barnes <jbarnes@sgi.com> > > > > to pci-sysfs.c if you do? > > Care to send me a new patch? Oh, and that copyright line needs to look > like: > * Copyright (c) 2004 Silicon Graphics, Inc. Jesse Barnes <jbarnes@sgi.com> > > to make it legal, or so my lawyers say :)
But I'm not the copyright holder, Silicon Graphics is, I just wanted people to know who to harass if something breaks :).
> > Greg was a little worried that your comment > > /* .size is set individually for each device, sysfs copies it into > > dentry */ might not be correct. > > I looked at the code, and he's right. But it's pretty scary that it > works correctly so I'd prefer to do it the way your patch did it (create > a new attribute for every entry.)
Ok. Jon?
Thanks, Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |