lkml.org 
[lkml]   [2004]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.6.8-rc4 [RESEND] via-rhine: Really call rhine_power_init()
This is my third and last attempt to get this fix merged for 2.6.8.

Without this patch, mainline via-rhine cannot wake the chip if some other
driver puts it to D3. The problem has hit quite a few people already.

This is a fix for the heisenbug with via-rhine refusing to work
sometimes. Patch "[9/9] Restructure reset code" contained a change made
necessary by patch [8/9]. Mainline merged [8/9] for 2.6.8 and is still
missing the fix, while -mm got it with [9/9].

Jesper Juhl provided crucial test data when no one else was able to
reproduce the symptoms.

Roger

Signed-off-by: Roger Luethi <rl@hellgate.ch>

--- tmp/drivers/net/via-rhine.c.00_broken 2004-07-29 13:58:17.000000000 +0200
+++ tmp/drivers/net/via-rhine.c 2004-07-30 15:12:36.656007543 +0200
@@ -748,6 +748,8 @@ static int __devinit rhine_init_one(stru
}
#endif /* USE_MMIO */
dev->base_addr = ioaddr;
+ rp = netdev_priv(dev);
+ rp->quirks = quirks;

rhine_power_init(dev);

@@ -792,10 +794,8 @@ static int __devinit rhine_init_one(stru

dev->irq = pdev->irq;

- rp = netdev_priv(dev);
spin_lock_init(&rp->lock);
rp->pdev = pdev;
- rp->quirks = quirks;
rp->mii_if.dev = dev;
rp->mii_if.mdio_read = mdio_read;
rp->mii_if.mdio_write = mdio_write;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:05    [W:1.420 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site