lkml.org 
[lkml]   [2004]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] Freescale MPC52xx support for 2.6 - Base part
    Kumar Gala wrote:

    > A few comments:
    >
    > cputable.c: * the 8280/52xx, maybe we should just have G2_LE, (same
    > core exists in 8272, 8249, etc.)

    IMHO, yes it may be better.

    > mpc52xx_setup.c: * what is cpu_52xx[]?

    A table with coefficients taken from datasheet. They're used to
    compute the core frequency according to XLB bus frequency and external
    jumper configurations.

    > ppcboot.h: * was bi_immr_base not sufficient?

    I suppose your question is why create bi_mbar_base instead of using immr.
    Well, I guess that would work just fine. The structure is just taken
    straight from U-Boot sources.

    If the question was if I really need to add fields for the frequency,
    then the answer is yes. (Else, I must measure them which takes times and
    is inherently less precise).


    Sylvain Munaut

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.019 / U:180.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site