lkml.org 
[lkml]   [2004]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Pcihpd-discuss] [PATCH] 2.6 PCI Hotplug: receive PPC64 EEH events
On Thu, Jul 08, 2004 at 10:04:33AM -0500, linas@austin.ibm.com wrote:
> On Wed, Jul 07, 2004 at 10:26:04PM -0700, Greg KH wrote:
> > On Wed, Jul 07, 2004 at 04:47:39PM -0500, linas@austin.ibm.com wrote:
> >
> > > ===== drivers/pci/hotplug/rpaphp.h 1.9 vs edited =====
> > > +extern void init_eeh_handler (void);
> > > +extern void exit_eeh_handler (void);
> >
> > This belongs in the eeh header file, not the rpaphp.h file.
>
> But these are implemented in rpaphp_pci.c and are called
> in rpaphp_core.c. Perchance a different function name, such as
> init_rpaphp_eeh_handler() be better?

Ah, yes, see I didn't even catch that :)

They should start with "rpaphp" as they are global symbols.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.118 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site