lkml.org 
[lkml]   [2004]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Unnecessary barrier in sync_page()?
Andrea Arcangeli <andrea@suse.de> wrote:
>
> however the smp_mb() isn't needed in sync_page, simply because it's
> perfectly ok if we start running sync_page before reading pagelocked.
> All we care about is to run sync_page _before_ io_schedule() and that we
> read PageLocked _after_ prepare_to_wait_exclusive.
>
> So the locking in between PageLocked and sync_page is _absolutely_
> worthless and the smp_mb() can go away.

IIRC, Chris added that barrier (and several similar) for the reads in
page_mapping().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.050 / U:5.212 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site