Messages in this thread | | | Date | Fri, 30 Jul 2004 14:29:30 -0700 | From | Greg KH <> | Subject | Re: [PATCH] add PCI ROMs to sysfs |
| |
On Fri, Jul 30, 2004 at 02:09:05PM -0700, Jesse Barnes wrote: > > Thoughts? I've tried to add cleanup code, but I'm not sure how acceptable it > is and I don't have any way of testing it.
You don't have access to a cardbus machine? Or how about using the fakephp driver to "remove" pci devices? You should be able to test this code path with either one of those methods...
> +void pci_remove_sysfs_dev_files(struct pci_dev *pdev) > +{ > + /* Don't need to free config entries since they're static & global */
What do you mean by this? You should still remove all files we added in the pci_create_sysfs_dev_files() function here, not just the rom file.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |