lkml.org 
[lkml]   [2004]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: procfs permissions on 2.6.x
Christoph Hellwig <hch@infradead.org> wrote:
>
> On Sat, Jul 03, 2004 at 10:22:42PM +0200, Herbert Poetzl wrote:
> >
> > Hi Andrew!
> >
> > stumbled over the following detail ...
> >
> > usually when somebody tries to modify an inode,
> > notify_change() calls inode_change_ok() to verify
> > the user's permissions ... now it seems that
> > somewhere around 2.5.41, a patch similar to this
> > one was included into the mainline, and remained
> > almost unmodified ...
> >
> > http://www.uwsg.iu.edu/hypermail/linux/kernel/0210.1/1002.html
> >
> > this probably unintentionally circumvents the
> > inode_change_ok() check, so that now any user
> > can modify inodes of the procfs.
> >
> > example:
> >
> > $ chmod a-rwx /proc/cmdline
> >
> > the following patch hopefully fixes this, so
> > please consider for inclusion ...
>
> Actually the patch you reference above looks extremly bogus and should just
> be reverted instead.

Why is it "extremely bogus"? I assume Olaf had a reason for wanting chmod
on procfs files?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:1.081 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site