Messages in this thread | | | Date | Wed, 28 Jul 2004 16:00:33 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Altix system controller communication driver |
| |
Greg Howard <ghoward@sgi.com> wrote: > > > > +static unsigned int > > > +scdrv_poll(struct file *file, struct poll_table_struct *wait) > > > +{ > > > + unsigned int mask = 0; > > > + int status = 0; > > > + struct subch_data_s *sd = (struct subch_data_s *) file->private_data; > > > + unsigned long flags; > > > + > > > + scdrv_lock_all(sd, &flags); > > > + poll_wait(file, &sd->sd_rq, wait); > > > + poll_wait(file, &sd->sd_wq, wait); > > > > This function will sleep with spinlocks held, won't it? > > My understanding is that poll_wait just sets up a poll_table > structure; it doesn't sleep itself.
It calls into __pollwait(), which can perform sleeping memory allocations. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |