lkml.org 
[lkml]   [2004]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] kernel events layer
    Robert Love <rml@ximian.com> wrote:
    >
    > + buffer = (char *) get_zeroed_page(gfp_mask);

    Why zeroed?

    > + if (!buffer)
    > + return -ENOMEM;
    > +
    > + snprintf(buffer, PAGE_SIZE, "From: %s\n", object);
    > + len = strlen(buffer);
    > + snprintf(buffer + len, PAGE_SIZE - len, "Signal: %s\n", signal);
    > + len = strlen(buffer);

    A single snprintf here would suit.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.021 / U:62.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site