Messages in this thread | | | Date | Thu, 22 Jul 2004 15:20:45 -0500 | From | Robin Holt <> | Subject | Re: Altix I/O code re-org |
| |
On Thu, Jul 22, 2004 at 08:42:31PM +0100, Christoph Hellwig wrote: > > PS: I found a few small problems with the bte code and will soon have > > another patch that fixes that up. Specifically, there were changes > > made to bte_error.c and pda.h that are undone by your patch. > > apropos bte, could you please merge bte_error.c into bte.c - there's no > external callers of functions in bte_error.c except in bte.c
bte.c doesn't call bte_error. That used to get called from shub_iio_error() or something like that. Would it be more appropriate to merge bte_error.c into the callers file? I would lean towards putting it into bte.c, but your previous add implied it should go into the callers file.
Thanks, Robin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |