Messages in this thread | | | Date | Thu, 15 Jul 2004 09:30:18 -0300 | From | Marcelo Tosatti <> | Subject | Re: [PARCH] driver core: add driver_find to find a driver by name |
| |
On Wed, Jul 14, 2004 at 04:02:46PM -0700, Greg KH wrote: > On Sun, Jun 27, 2004 at 09:26:03PM -0500, Dmitry Torokhov wrote: > > Hi, > > > > Here is a patch that adds driver_find() that allows to search for a driver > > on a bus by it's name. The function is similar to device_find already present > > in the tree. I need it for my serio sysfs patches where user can re-bind > > serio port to an alternate driver by echoing driver's name to serio port's > > driver attribute. > > Applied, thanks.
Dmitry,
I remember you fixed kset_find_obj() to get a reference count on the kobject.
driver_find()/device_find() use that, maybe it would be nice to add a comment on top of those saying the caller is responsible for putting the refcount on the kobject?
Last time I looked at your patches there was no such comment on driver_find/device_find, only kset_find_obj().
Just nitpicking. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |