lkml.org 
[lkml]   [2004]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pmac_zilog: initialize port spinlock on all init paths
    On Mon, Jul 12, 2004 at 11:16:34PM -0500, Benjamin Herrenschmidt wrote:
    > On Mon, 2004-07-12 at 19:39, David Eger wrote:
    > > Dear Ben,
    > >
    > > This patch fixes the Zilog driver so it doesn't freak on my TiBook.
    > > [patch that initializes port->lock in pmac_zilog.c
    >
    > The spinlock should be initialized by the serial core when registering
    > the ports ... can you find out for me how do you end up with the
    > port not registered but still trying to use the lock ?

    After some testing, I found that the pmac_zilog Oops (which claims we've
    not initialized port->lock) only occurs when I also enable 8250/16550
    serial support (CONFIG_SERIAL_8250)

    I'll try to track down what's going on on the plane tomorrow, but I'm
    curious to hear if any of the recent csets might have caused this...
    (hence the cc: rmk)

    > > ( of course, it still spews diahrea of 'IN from bad port XXXXXXXX'
    > > but then, I don't have the hardware.... still, seems weird that OF
    > > would report that I do have said hardware :-/ )
    >
    > The IN from bad port is a different issue, it's probably issued by
    > another driver trying to tap legacy hardware, either serial.o or
    > ps/2 kbd, I suppose, check what else of that sort you have in your
    > .config

    Sure enough, the "IN from bad port XXXXXXXX" ended up being the i8042
    serial PC keyboard driver, enabled with CONFIG_SERIO_I8042. Don't know
    why that's in ppc defconfig....

    -dte
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:04    [W:0.020 / U:1.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site